Fix test failures stemming from exception handling changes #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 4 test failures related to NotFoundException behavior changes: 1. SQSEventQueueE2ESpec.groovy:420 - Convert Groovy GString to String when passing to AWS SDK - Fixes ClassCastException in setQueueAttributes call 2. QueueResiliencySpec.groovy:517 - getTaskLogs test - Add thrown(NotFoundException) expectation - TaskResource.getTaskLogs now throws NotFoundException for missing tasks 3. QueueResiliencySpec.groovy:525 - getTask test - Add thrown(NotFoundException) expectation - TaskResource.getTask now throws NotFoundException for missing tasks 4. AbstractHttpEndToEndTest.java:451 - testTaskByTaskId - Update error message assertion from "No such task found by" to "Task not found for" - Matches new error message format from PR #69 Related to issue #602 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
nthmost-orkes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Fixes 4 test failures related to NotFoundException behavior changes:
SQSEventQueueE2ESpec.groovy:420
QueueResiliencySpec.groovy:517 - getTaskLogs test
QueueResiliencySpec.groovy:525 - getTask test
AbstractHttpEndToEndTest.java:451 - testTaskByTaskId
Related to issue #602
No new functionality, just catching up on tech debt.