Use the async a_embed_text in _a_get_n_random_contexts_per_source_file.#1641
Merged
penguine-ip merged 1 commit intoconfident-ai:mainfrom May 29, 2025
Merged
Use the async a_embed_text in _a_get_n_random_contexts_per_source_file.#1641penguine-ip merged 1 commit intoconfident-ai:mainfrom
penguine-ip merged 1 commit intoconfident-ai:mainfrom
Conversation
Using the sync method breaks parallelization and hurts performance as it halts the thread in which the event loop is running.
|
Someone is attempting to deploy a commit to the Confident AI Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
@andreasgabrielsson thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context and Purpose
When running golden generation in async mode using
a_generate_goldens_from_docsthe context generator is still calling the sync version ofDeepEvalBaseEmbeddingModel.embed_text. The sync version ofembed_textperforms a blocking call to the embedding model and will block the entire thread in which the event loop is being executed. This breaks parallelization and hurts performance significantly.Depending on how the
DeepEvalBaseEmbeddingModelis implemented, it also risks crashing the entire application. For example if the implementation of the sync methods looks like in the screenshot below, it crashes with this error message:RuntimeError: asyncio.run() cannot be called from a running event loop.This PR fixes the error by calling the async method
a_embed_textinstead.