Update prompts to include branch methods#2583
Merged
Merged
Conversation
|
@A-Vamshi is attempting to deploy a commit to the Confident AI Team on Vercel. A member of the Team first needs to authorize it. |
penguine-ip
reviewed
Mar 31, 2026
Contributor
There was a problem hiding this comment.
Need to add branch to cache too
| HINT_TEXT = f"version={version}" | ||
| else: | ||
| HINT_TEXT = f"hash={hash or 'latest'}" | ||
| HINT_TEXT = f"hash={hash or 'latest'}, branch={branch or self.branch}" |
Contributor
There was a problem hiding this comment.
branch={self.branch or 'main'}
penguine-ip
reviewed
Mar 31, 2026
| PROMPTS_COMMITS_ENDPOINT = "/v1/prompts/:alias/commits" | ||
| PROMPTS_COMMIT_HASH_ENDPOINT = "/v1/prompts/:alias/commits/:hash" | ||
| PROMPTS_BRANCHES_ENDPOINT = "/v1/prompts/:alias/branches" | ||
| PROMPTS_BRANCH_ENDPOINT = "/v1/prompts/:alias/branches/:branch" |
Contributor
There was a problem hiding this comment.
Is this :branch name or :branch id?
Collaborator
Author
There was a problem hiding this comment.
This is the branch name so the :branch will be replaced by 'main' or any other name we might have
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.