add ambiguous claims to contradictions when penalized is true#2644
Merged
penguine-ip merged 1 commit intoMay 12, 2026
Merged
Conversation
|
@miafig is attempting to deploy a commit to the Confident AI Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
@miafig thank you this is a nice addition, this will make it to the next release :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
penalize_ambiguous_claims=TrueinFaithfulnessMetric, the reason generated is positive even if when there are penalizations from ambiguous claims.This happens because the ambiguous claims are not counted as contradictions in
_generate_reason().Fix
Add all ambiguous claims to the
contradictionslist whenpenalize_ambiguous_claims=True.