Skip to content

Fix task completion tool prompt rendering#2814

Open
luochen211 wants to merge 3 commits into
confident-ai:mainfrom
luochen211:fix-task-completion-tools-called-template
Open

Fix task completion tool prompt rendering#2814
luochen211 wants to merge 3 commits into
confident-ai:mainfrom
luochen211:fix-task-completion-tools-called-template

Conversation

@luochen211

Copy link
Copy Markdown

Summary

  • format tools_called before rendering TaskCompletionMetric's extract_goal_and_outcome template
  • cover sync and async prompt construction with regression tests

Fixes #2807

Tests

  • /tmp/deepeval-pr-venv/bin/python -m pytest tests/test_metrics/test_task_completion_prompt.py
  • python3 -m pytest tests/test_templates/test_metric_templates.py

@vercel

vercel Bot commented Jun 28, 2026

Copy link
Copy Markdown

@luochen211 is attempting to deploy a commit to the Confident AI Team on Vercel.

A member of the Team first needs to authorize it.

@luochen211

Copy link
Copy Markdown
Author

GitHub Actions are green after formatting with the current Black version. The only remaining failing status is Vercel, which says a Confident AI team member needs to authorize the deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] TestCompleteMetric pass the wrong variable 'tools_called' to jinja which expect 'tools_called_formatted' to be received

1 participant