Skip to content

Fix red main CI: format TypeScript sources with Prettier#2823

Open
HarperZ9 wants to merge 1 commit into
confident-ai:mainfrom
HarperZ9:fix/typescript-lint-prettier
Open

Fix red main CI: format TypeScript sources with Prettier#2823
HarperZ9 wants to merge 1 commit into
confident-ai:mainfrom
HarperZ9:fix/typescript-lint-prettier

Conversation

@HarperZ9

Copy link
Copy Markdown

Problem

The TypeScript Lint workflow (.github/workflows/typescript_lint.yml) runs:

npx prettier --check "src/**/*.ts" "test/**/*.ts"

On main this currently fails with Code style issues found in 66 files, which exits non-zero and (via fail-fast) cancels the rest of the TypeScript CI matrix.

Change

Ran prettier --write "src/**/*.ts" "test/**/*.ts" using the pinned prettier@3.6.2 from typescript/package.json. This is formatting-only (no behavioral changes) and is exactly what the failing step asks for ("Run Prettier with --write to fix.").

After this change, npx prettier --check "src/**/*.ts" "test/**/*.ts" reports All matched files use Prettier code style!.

The two pre-existing eslint warnings (unused SLUG_PATTERN and confidentApiKey) are intentionally left out of scope, since they are warnings and do not fail the build.

The TypeScript Lint workflow runs
`prettier --check "src/**/*.ts" "test/**/*.ts"` and currently fails on
main with "Code style issues found in 66 files", which cancels the rest
of the TypeScript CI matrix.

This applies `prettier --write` (pinned prettier 3.6.2 from
typescript/package.json) over those files and contains no other changes,
so the lint job passes again. The two pre-existing eslint unused-variable
*warnings* are left untouched as they do not fail the build.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Confident AI Team on Vercel.

A member of the Team first needs to authorize it.

@HarperZ9

HarperZ9 commented Jul 2, 2026

Copy link
Copy Markdown
Author

A quick CI note so the red status is easier to interpret:

  • The TypeScript lint check passed on this PR, which is the check this formatting-only PR is meant to address.
  • The failing test job is failing in credential-dependent integration suites, not on a formatting assertion. The job env shows empty credentials:
    • OPENAI_API_KEY:
    • CONFIDENT_API_KEY:
  • The failures then come from those missing/empty keys, e.g. OpenAI returns 401 Incorrect API key provided: '', and Confident API setup throws Please provide a valid Confident AI API Key.
  • Recent main runs for TypeScript Tests are also red, including the June 30 run on 11375f81, so this does not appear to be introduced by the Prettier-only changes here.
  • Vercel is still the fork-deploy authorization check.

I left the branch scoped to formatting because changing test credential behavior would be a separate CI/test policy change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant