Fix red main CI: format TypeScript sources with Prettier#2823
Open
HarperZ9 wants to merge 1 commit into
Open
Conversation
The TypeScript Lint workflow runs `prettier --check "src/**/*.ts" "test/**/*.ts"` and currently fails on main with "Code style issues found in 66 files", which cancels the rest of the TypeScript CI matrix. This applies `prettier --write` (pinned prettier 3.6.2 from typescript/package.json) over those files and contains no other changes, so the lint job passes again. The two pre-existing eslint unused-variable *warnings* are left untouched as they do not fail the build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the Confident AI Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
A quick CI note so the red status is easier to interpret:
I left the branch scoped to formatting because changing test credential behavior would be a separate CI/test policy change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The TypeScript Lint workflow (
.github/workflows/typescript_lint.yml) runs:On
mainthis currently fails withCode style issues found in 66 files, which exits non-zero and (via fail-fast) cancels the rest of the TypeScript CI matrix.Change
Ran
prettier --write "src/**/*.ts" "test/**/*.ts"using the pinnedprettier@3.6.2fromtypescript/package.json. This is formatting-only (no behavioral changes) and is exactly what the failing step asks for ("Run Prettier with --write to fix.").After this change,
npx prettier --check "src/**/*.ts" "test/**/*.ts"reportsAll matched files use Prettier code style!.The two pre-existing eslint warnings (unused
SLUG_PATTERNandconfidentApiKey) are intentionally left out of scope, since they are warnings and do not fail the build.