optimize tracing hot paths and add OOM protection#2828
Open
theanuragg wants to merge 3 commits into
Open
Conversation
|
@theanuragg is attempting to deploy a commit to the Confident AI Team on Vercel. A member of the Team first needs to authorize it. |
b584e80 to
cc68f5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the three hottest tracing code paths identified during profiling and adds OOM protection to
TraceManagerto prevent unbounded memory growth.Changes
maxTracesconfig option (default0= unlimited). When the limit is exceeded, evict the oldest traces from bothtraces[]andactiveTraces, preventing unbounded growth in long‑running eval pipelines.createTraceApi— replace the recursiveprocessSpans()closure with an explicit stack-based traversal to eliminate per‑level function call overhead when walking the span tree.convertSpanToApiSpan— remove dead_inputData/_outputDatavariables and seven redundant property reassignments, and movemetadatainto the initial object literal for a tighter hot path.createNestedSpansDict— inline the per‑call closure and drop the unused null‑coalescing logic aroundchildrenfor a simpler, cheaper span‑to‑dict conversion.Performance
createTraceApi (10 spans): 140,746 ops/s → 157,416 ops/s (+11.8%)createTraceApi (85 spans): 6,356 ops/s → 6,932 ops/s (+9.1%)observe() wrapper (no-op): 336,238 ops/s → 362,916 ops/s (+7.9%)