helm: add cert-manager as dependency #2793
Conversation
|
@wainersm @stevenhorsman I was planning to update the approach on the previous PR that just got merged, but you guys are on fire and merged before I send a push :) (thanks for that). So I will let this here for review... I could rebase here, after @wainersm 's PR is merged first. |
| > [!WARNING] | ||
| > The webhook is enabled by default and requires cert-manager for TLS certificates. | ||
| > By default, cert-manager will be installed automatically (`webhook.certManager.install=true`). | ||
| > If cert-manager is already installed in your cluster, set `--set webhook.certManager.install=false`. |
There was a problem hiding this comment.
Hi @beraldoleal ,
What's the consequence of trying to install the cert-manager if it is already in the cluster? Will it assume the dependency is match and move on? Or try to update the installed version and move on? Or will do something else? (hope it won't put the cluster in bad state)
There was a problem hiding this comment.
My understanding is that this has some cluster wide resources (like CRDs) and that will fail / conflict. The helm installation would abort, could let the peerpods chart in partial state. You would need to do helm uninstall and try again with the flag set to false.
claude, told-me that it has a flag called "--atomic" that would do that rollback automatically but I never used. From the --help:
" if set, the installation process deletes the installation on failure. The --wait flag will be set automatically if --atomic is used"
(So maybe we should test and document that flag)
I can test it in my PR. However, I will wait on your reply to my comment (double install cert-manager)...just in case...things my change :) |
Webhook requires cert-manager and is enabled by default. But users can disable installation if have them already installed. Signed-off-by: Beraldo Leal <[email protected]>
beraldoleal
force-pushed
the
charts-certmanager-dep
branch
from
48a4bf8 to
dc69448
Compare
2 participants
Webhook requires cert-manager and is enabled by default. But users can disable installation if have them already installed.