Skip to content
This repository was archived by the owner on Feb 1, 2026. It is now read-only.

Conversation

@ldoktor
Copy link
Contributor

@ldoktor ldoktor commented Aug 13, 2025

This is only cosmetic change, shouldn't result in different params.

Based on change from #535

@ldoktor ldoktor requested a review from a team as a code owner August 13, 2025 11:48
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was wondering about these too...

@mythi
Copy link
Contributor

mythi commented Aug 13, 2025

@ldoktor looks like this needs rebasing.

This is only cosmetic change, shouldn't result in different params.

Signed-off-by: Lukáš Doktor <[email protected]>
@ldoktor ldoktor force-pushed the ccruntime-gh-workflow branch from 73ada0e to d609b95 Compare August 13, 2025 13:12
@mythi
Copy link
Contributor

mythi commented Aug 13, 2025

e2e-pr / operator tests (kata-qemu-tdx, ubuntu-24.04) is passing here

@ldoktor
Copy link
Contributor Author

ldoktor commented Aug 20, 2025

The ubuntu 22.04 failure is "no space left on the device"... We'll perhaps need a cleanup again.

Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ldoktor !

@wainersm wainersm merged commit dc56fc8 into confidential-containers:main Aug 21, 2025
34 of 42 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants