Skip to content

kbs-client: fixup get-reference-value #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fitzthum merged 1 commit into from
Mar 9, 2026
Merged

kbs-client: fixup get-reference-value #1213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tools/kbs-client/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,16 +307,17 @@ pub async fn set_sample_rv(
}
}

pub async fn get_rvs(
pub async fn get_rv(
url: String,
auth_key: String,
kbs_root_certs_pem: Vec<String>,
reference_value_id: String,
) -> Result<String> {
let token = sign_admin_token(&auth_key)?;

let http_client = build_http_client(kbs_root_certs_pem)?;

let reference_value_url = format!("{}/{KBS_URL_PREFIX}/reference-value", url);
let reference_value_url = format!("{}/{KBS_URL_PREFIX}/reference-value/{reference_value_id}", url);

let res = http_client
.get(reference_value_url)
Expand Down
12 changes: 8 additions & 4 deletions tools/kbs-client/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,12 @@ enum ConfigCommands {
resource_file: PathBuf,
},

/// List reference values registered with RVPS
GetReferenceValues,
/// Get reference value from RVPS given reference value ID
GetReferenceValue {
/// The ID of the reference value.
#[clap(long, value_parser)]
id: String,
},

/// Add a sample reference value to the RVPS.
/// The request will be proxied through the KBS
Expand Down Expand Up @@ -369,9 +373,9 @@ async fn main() -> Result<()> {
.await?;
println!("Reference Values Updated");
}
ConfigCommands::GetReferenceValues => {
ConfigCommands::GetReferenceValue { id } => {
let values =
kbs_client::get_rvs(cli.url, auth_key.clone(), kbs_cert.clone()).await?;
kbs_client::get_rv(cli.url, auth_key.clone(), kbs_cert.clone(), id).await?;
println!("{:?}", values);
}
}
Expand Down
Loading