nvidia: use alias for remote verifier type#1216
Merged
dcmiddle merged 1 commit intoconfidential-containers:mainfrom Mar 11, 2026
Merged
nvidia: use alias for remote verifier type#1216dcmiddle merged 1 commit intoconfidential-containers:mainfrom
dcmiddle merged 1 commit intoconfidential-containers:mainfrom
Conversation
dcmiddle
approved these changes
Mar 11, 2026
Member
|
@Xynnn007 ptal |
Member
|
@manuelh-dev might need a rebase for the latest fix |
Avoid having to pass capitalized NVIDIA_VERIFIER_MODE strings to deploy KBS. Signed-off-by: Manuel Huber <manuelh@nvidia.com>
manuelh-dev
force-pushed
the
mahuber/nv-remote-ver-fix
branch
from
dcc13f0 to
14ed3ba
Compare
dcmiddle
merged commit f5cb8fc
into
confidential-containers:main
47 of 48 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid having to pass capitalized NVIDIA_VERIFIER_MODE strings to deploy KBS.
I am trying to integrate the latest version of trustee into kata-containers: https://github.com/kata-containers/kata-containers/pull/12648/changes
After adjusting the
NVIDIA_VERIFIER_MODEvariable, I still got CI errors such as in https://github.com/kata-containers/kata-containers/actions/runs/22917620305/job/66510316119?pr=12648:Looks like this contract "broke" yesterday via: 8733c99
If you don't like the serialization alias, we would at least need to change
kbs\config\kubernetes\deploy-kbs.sh, for instance, assigningLocalas the default value forNVIDIA_VERIFIER_MODEwhen no value is present (or ensure the value is either local or remote and capitalize the first value).Oddly enough, even after adjusting
NVIDIA_VERIFIER_MODEtoRemotein kata-containers, the NVIDIA GPU SNP CI failed: https://github.com/kata-containers/kata-containers/actions/runs/22917620305/job/66510316119?pr=12648Bluntly starting at the code, I don't see where the capitalization got lost. I don't see a trace on kata side and on
deploy-kbs.shside, the capital R version should have been utilized.