fix(nvidia remote verifier): NRAS response length correction - #1573
Open
valzaitsev wants to merge 1 commit into
Open
fix(nvidia remote verifier): NRAS response length correction#1573valzaitsev wants to merge 1 commit into
valzaitsev wants to merge 1 commit into
Conversation
Signed-off-by: Valentin Zaitsev <8722423+valzaitsev@users.noreply.github.com>
Xynnn007
approved these changes
Aug 18, 2026
Xynnn007
left a comment
Xynnn007
left a comment
Member
There was a problem hiding this comment.
Thanks @valzaitsev ! I brought in the bug but luckily it will be fixed. Only one comment
| let response: NrasResponseInternal = serde_json::from_str(s)?; | ||
|
|
||
| if response.1.len() != 2 { | ||
| //Expect 2 elements in the NRAS payload |
Member
There was a problem hiding this comment.
We do not need this comment, just add it to commit message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first field of NRAS response consists of two elements: string "JWT" and base64 of actual JWT. But due to the typo the code was checking the length of the second field. Because of that all valid NRAS responses were failing with "Unexpected Payload Format" error. This PR fixes that, so NRAS responses are properly processed by nvidia verifier in remote mode.