APIE-812: Add GCP support in connect artifact commands#3255
APIE-812: Add GCP support in connect artifact commands#3255Himanshu Singla (hisingla12) wants to merge 4 commits intomainfrom
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
This PR adds support for Google Cloud Platform (GCP) in the connect artifact commands, expanding the CLI's cloud provider capabilities beyond AWS and Azure.
Changes:
- Updated connect artifact commands (create, list, describe, delete) to support GCP cloud provider
- Added comprehensive test coverage for GCP artifact operations including JAR and ZIP formats
- Updated validation logic and error messages to include GCP as a supported cloud provider
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/connect/command_artifact_create.go | Added GCP to supported clouds list, updated error message, and implemented GCP-specific upload logic |
| internal/connect/command_artifact_list.go | Changed flag from AWS/Azure-specific to generic cloud flag |
| internal/connect/command_artifact_describe.go | Changed flag from AWS/Azure-specific to generic cloud flag |
| internal/connect/command_artifact_delete.go | Changed flag from AWS/Azure-specific to generic cloud flag |
| test/connect_test.go | Added comprehensive test cases for GCP artifact operations (create, list, describe, delete) |
| test/test-server/connect_handler.go | Added GCP test artifacts and updated handlers to recognize GCP artifact IDs |
| test/fixtures/output/connect/artifact/*.golden | Added golden files for GCP artifact operation outputs in various formats (table, JSON, YAML) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Himanshu Singla (hisingla12)
left a comment
There was a problem hiding this comment.
Checking for any issues with this PR implementation...
Daniel Ayaz (danielayaz)
left a comment
There was a problem hiding this comment.
It looks like there are some failing tests in the PR pipeline
|
|
Daniel Ayaz (@danielayaz) I have fixed the test. |




Release Notes
New Features
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Cli support for connect artifact upload for csmt connectors was already enabled for AWS and Azure, with this PR we are enabling/supporting it for GCP
Blast Radius
Changes affect Upload artifact flow for connect artifacts
References
https://confluentinc.atlassian.net/browse/APIE-812
Test & Review
This PR has been tested by building the binary, and testing against stag environment (stag.cpdev.cloud). Testing has been done for all CSPs - AWS, Azure and GCP
List artifact AWS ✅

List artifact Azure ✅

List artifact GCP ✅

Create artifact AWS ✅

Create artifact Azure ✅

Create artifact GCP ✅

Describe Artifact AWS ✅

Describe Artifact Azure ✅

Describe Artifact GCP ✅

Delete Artifact AWS ✅

Delete Artifact Azure ✅

Delete Artifact GCP ✅
