Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add editorconfig #2285

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add editorconfig #2285

wants to merge 2 commits into from

Conversation

anchitj
Copy link
Member

@anchitj anchitj commented Aug 16, 2024

Also format the whole codebase

anchitj added 2 commits August 14, 2024 20:24
@anchitj
Add editorconfig (#9)
564aa11 
Also ran formatter through the whole codebase
@anchitj
Second half of changes (2/2) (#10)
395328b
@anchitj anchitj requested review from a team as code owners August 16, 2024 09:07
Havret
Havret suggested changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@Havret Havret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big -1. I see value in adding an .editorconfig, but formatting the entire codebase would be disruptive, to say the least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Havret Havret Havret requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anchitj @Havret