Use ConcurrentDictionary as default cache for Schema Registry client #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request replaces several thread-unsafe Dictionary instances with thread-safe ConcurrentDictionary variants in the Schema Registry client to improve performance in concurrent scenarios.
- Replaces Dictionary with ConcurrentDictionary for cache-related variables.
- Adds fast-path checks to avoid acquiring locks when a cache hit is detected.
|
/sem-approve |
…ma_registry_client
|
/sem-approve |
1 similar comment
|
/sem-approve |
rayokota
approved these changes
Mar 28, 2025
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR is a follow-up to #2429.
It replaces the thread-unsafe Dictionary with its thread-safe variant, ConcurrentDictionary.
The main goal is to eliminate the need to acquire a lock for cache lookups, improving performance in concurrent scenarios.
Checklist
@rayokota Could you please take a look?