Skip to content

fix(idempotency): make kafka-storage commands return correct changed_when status #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 7.9.x
Choose a base branch
from

Conversation

sverrehu
Copy link

Description

Before this PR, in KRaft mode, commands running kafka-storage had no explicit changed_when, so they would always report that they changed the system.

This PR sets changed_when: false for kafka-storage info and kafka-storage random-uuid, none of which changes anything on the hosts. It also sets changed_when for the kafka-storage format command, based on the output from the command.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested in our local provisioning pipeline.

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@sverrehu sverrehu requested a review from a team as a code owner February 10, 2025 08:35
@sverrehu
Copy link
Author

*knock, knock*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant