Skip to content

[ANSIENG-4727] | updating internal token listener to be created whenv… #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 7.8.x
Choose a base branch
from

Conversation

rrbadiani
Copy link
Member

@rrbadiani rrbadiani commented Apr 15, 2025

Description

Internal token listener was created so rest proxy can have some sasl_ssl based listener in case internal listener was based on SSL security protocol. Thus the condition to create it was auth_mode == mtls but for brownfield migration we need that listener before removing the ldap oauth configs and thus we should not wait until auth_mode == mtls but rather create this internal token listener when mds has mtls`

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

semaphore job

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@rrbadiani rrbadiani requested a review from a team as a code owner April 15, 2025 04:56
@rrbadiani rrbadiani changed the title [Test-in-progress-do-not-review][ANSIENG-4727] | updating internal token listener to be created whenv… [ANSIENG-4727] | updating internal token listener to be created whenv… Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants