Fix: kafka-connect connectors deployment in serial mode #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes subgroup handling completely. Only handles single kafka_connect cluster. Fixing defect when rbac mode is enabled and hosts.yml connect cluster hosts are child grouping.
And ensure that it is only run once per cluster in serial mode as well
Author
|
This PR is currently lacking kafka-connect subgroup handling. |
sami-airaksinen
commented
Jul 4, 2025
| --- | ||
| - name: Register Kafka Connect Subgroups | ||
| set_fact: | ||
| subgroups: "{{ ((subgroups | default([])) + hostvars[item].group_names) | difference('kafka_broker, ksql, kafka_connect, kafka_rest, kerberos, ksql, schema_registry, kafka_broker_parallel, ksql_parallel, kafka_connect_parallel, kafka_rest_parallel, kerberos_parallel, ksql_parallel, schema_registry_parallel, kafka_controller, kafka_controller_parallel') }}" |
Author
There was a problem hiding this comment.
Comment: we have investigated and this seems to be not working as it is expected to work. The difference() function expects an (array, array) as input, but here it consumes (array, string). It doesn't fail, because it implicitly converts str to array of characters.
sami-airaksinen
commented
Jul 4, 2025
| vars: | ||
| - connect_cluster_workers: [] | ||
| set_fact: | ||
| active_kafka_connect_groups: "{{ (((active_kafka_connect_groups | default([])) + hostvars[item].group_names) | difference('kafka_connect'+'kafka_connect_parallel'+'kafka_connect_serial'+ 'kafka_broker'+ 'kafka_broker_parallel'+'kafka_broker_serial'+'ksql'+ 'ksql_parallel'+'ksql_serial'+'control_center_next_gen'+'control_center_next_gen_parallel'+'control_center_next_gen_serial'+'schema_registry'+'kafka_rest'+'kafka_rest_parallel'+'kafka_rest_serial'+'kafka_controller'+'kafka_controller_parallel'+'kafka_controller_serial')) | default(['kafka_connect'], true) }}" |
Author
There was a problem hiding this comment.
Comment: original code has same issue as explained in https://github.com/confluentinc/cp-ansible/pull/2161/files#r2185136443 .
sami-airaksinen
commented
Jul 4, 2025
| parent_kafka_connect_cluster_group: "{{ (group_names | difference(keywords))[0] | default('kafka_connect') }}" | ||
| parent_kafka_connect_cluster_id: "{{ kafka_connect_final_properties['group.id'] }}" | ||
|
|
||
| # TODO needs to be ran over kafka-connect subgroups (i.e. multiple kafka-connect clusters in same inventory) |
Author
There was a problem hiding this comment.
I would like to discuss with someone about how to implement this subgroup in this or higher level.
| - inventory_hostname == ansible_play_hosts_all[0] # for serial mode playbook | ||
| run_once: true | ||
|
|
||
| # TODO needs to be ran over kafka-connect subgroups (i.e. multiple kafka-connect clusters in same inventory) |
Author
There was a problem hiding this comment.
I would like to discuss with someone about how to implement this subgroup in this or higher level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2160
This PR also tries to simplify how role
kafka-connectsregister_clusteranddeploy_connectorsare ran and configured in case where inventory contains multiple kafka-connect clusters.Type of change
How Has This Been Tested?
Currently only in our test environment, but I would be keen to create a test case for this so that we can create a regression test case to this.
Checklist: