-
Notifications
You must be signed in to change notification settings - Fork 418
[ANSIENG-5684] | connectors deployment fix #2353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.9.x
Are you sure you want to change the base?
Changes from 2 commits
b4502a4
f610fa1
c8c628d
3025c58
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| --- | ||
| - name: Register Kafka Connect Subgroups | ||
| set_fact: | ||
| subgroups: "{{ ((subgroups | default([])) + hostvars[item].group_names) | difference('kafka_broker, ksql, kafka_connect, kafka_rest, kerberos, ksql, schema_registry, zookeeper, kafka_broker_parallel, ksql_parallel, kafka_connect_parallel, kafka_rest_parallel, kerberos_parallel, ksql_parallel, schema_registry_parallel, zookeeper_parallel, kafka_controller, kafka_controller_parallel') }}" | ||
| subgroups: "{{ ((subgroups | default([])) + hostvars[item].group_names) | difference(['kafka_broker', 'ksql', 'kafka_connect', 'kafka_rest', 'kerberos', 'schema_registry', 'zookeeper', 'kafka_broker_parallel', 'ksql_parallel', 'kafka_connect_parallel', 'kafka_rest_parallel', 'kerberos_parallel', 'ksql_parallel', 'schema_registry_parallel', 'zookeeper_parallel', 'kafka_controller', 'kafka_controller_parallel']) }}" | ||
| with_items: "{{groups['kafka_connect']}}" | ||
|
|
||
| - name: Extract Connect Principal from cert | ||
|
|
@@ -79,6 +79,11 @@ | |
| - subgroups|length == 0 | ||
| run_once: true | ||
|
|
||
| - name: Filter subgroups for rolling deployment strategy | ||
| set_fact: | ||
| filtered_subgroups: "{{ [parent_kafka_connect_cluster_group] if ((kafka_connect_deployment_strategy == 'rolling' or kafka_connect_deployment_strategy == 'serial') and parent_kafka_connect_cluster_group is defined and parent_kafka_connect_cluster_group in subgroups) else subgroups }}" | ||
| when: subgroups is defined | ||
|
||
|
|
||
| - name: Register connector configs and remove deleted connectors for Multiple Clusters | ||
| confluent.platform.kafka_connectors: | ||
| connect_url: "http{% if hostvars[groups[item][0]].kafka_connect_ssl_enabled|default(kafka_connect_ssl_enabled) %}s{% endif %}://{{ hostvars[groups[item][0]] | confluent.platform.resolve_and_format_hostname }}:{{ hostvars[groups[item][0]].kafka_connect_rest_port|default(kafka_connect_rest_port) }}/connectors" | ||
|
|
@@ -89,5 +94,5 @@ | |
| client_key: "{% if hostvars[groups[item][0]].kafka_connect_ssl_mutual_auth_enabled|default(kafka_connect_ssl_mutual_auth_enabled) %}{{hostvars[groups[item][0]].kafka_connect_key_path|default(kafka_connect_key_path)}}{% else %}{{none}}{% endif %}" | ||
| when: hostvars[groups[item][0]].kafka_connect_connectors is defined | ||
| delegate_to: "{{ groups[item][0] }}" | ||
| loop: "{{subgroups}}" | ||
| loop: "{{ filtered_subgroups | default(subgroups) }}" | ||
|
||
| run_once: true | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -509,13 +509,4 @@ | |
|
|
||
| - name: Deploy Connectors | ||
| include_tasks: deploy_connectors.yml | ||
|
|
||
| - name: Delete temporary keys/certs when keystore and trustore is provided | ||
| file: | ||
| path: "{{item}}" | ||
| state: absent | ||
| loop: | ||
| - "{{kafka_connect_ca_cert_path}}" | ||
| - "{{kafka_connect_cert_path}}" | ||
| - "{{kafka_connect_key_path}}" | ||
| when: (ssl_provided_keystore_and_truststore | bool) | ||
| tags: deploy_connectors | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this tag included here?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This would be a helpful feature for customer to be able to skip deploying connectors during their upgrads if they want to.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does this work ? |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we give this proxy_env here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
customer can set proxy env vars, hence added it here as well