Ubuntu dockerfile fix 79#2498
Open
Rohan Kunwar (rkunwar-28) wants to merge 5 commits into
Open
Conversation
…-ansible into ubuntu-dockerfile-fix-79
There was a problem hiding this comment.
Pull request overview
This PR updates Molecule assets to make Ubuntu-based test containers more reliable by ensuring required packages are present and APT metadata is refreshed before installs.
Changes:
- Add
rsyncto the Ubuntu Java 11 “lean” Molecule Dockerfile package install list. - Enable APT cache updates for Debian installs in
molecule/certificates.ymlto avoid failures from stale/missing package indexes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| molecule/Dockerfile-ubuntu-java11-lean.j2 | Installs rsync alongside Java/tools during image build. |
| molecule/certificates.yml | Adds update_cache to Debian apt tasks used during certificate generation setup. |
Comments suppressed due to low confidence (1)
molecule/certificates.yml:37
update_cacheis enabled on both Debian apt tasks. Since the first task already runs for all Debian hosts, the second task will trigger an additionalapt-get update(Ansible apt defaultscache_valid_timeto 0 when updating), which adds avoidable time and flakiness in CI. Consider removingupdate_cachefrom this second task (or using a non-zerocache_valid_timeon the first update) and also align the boolean style with the repo’supdate_cache: trueconvention.
apt:
name:
- openjdk-11-jdk
state: present
update_cache: yes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
25
to
+29
| name: | ||
| - openssl | ||
| - rsync | ||
| state: present | ||
| update_cache: yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: