Skip to content

Ubuntu dockerfile fix 79#2498

Open
Rohan Kunwar (rkunwar-28) wants to merge 5 commits into
masterfrom
ubuntu-dockerfile-fix-79
Open

Ubuntu dockerfile fix 79#2498
Rohan Kunwar (rkunwar-28) wants to merge 5 commits into
masterfrom
ubuntu-dockerfile-fix-79

Conversation

@rkunwar-28
Copy link
Copy Markdown
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@rkunwar-28 Rohan Kunwar (rkunwar-28) requested a review from a team as a code owner May 20, 2026 04:04
Copilot AI review requested due to automatic review settings May 20, 2026 04:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Molecule assets to make Ubuntu-based test containers more reliable by ensuring required packages are present and APT metadata is refreshed before installs.

Changes:

  • Add rsync to the Ubuntu Java 11 “lean” Molecule Dockerfile package install list.
  • Enable APT cache updates for Debian installs in molecule/certificates.yml to avoid failures from stale/missing package indexes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
molecule/Dockerfile-ubuntu-java11-lean.j2 Installs rsync alongside Java/tools during image build.
molecule/certificates.yml Adds update_cache to Debian apt tasks used during certificate generation setup.
Comments suppressed due to low confidence (1)

molecule/certificates.yml:37

  • update_cache is enabled on both Debian apt tasks. Since the first task already runs for all Debian hosts, the second task will trigger an additional apt-get update (Ansible apt defaults cache_valid_time to 0 when updating), which adds avoidable time and flakiness in CI. Consider removing update_cache from this second task (or using a non-zero cache_valid_time on the first update) and also align the boolean style with the repo’s update_cache: true convention.
      apt:
        name:
          - openjdk-11-jdk
        state: present
        update_cache: yes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread molecule/certificates.yml
Comment on lines 25 to +29
name:
- openssl
- rsync
state: present
update_cache: yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants