MINOR: Reduce repetitive logs on large queries by adjusting connection logging#1494
Open
Dugong (Dugong42) wants to merge 1 commit intoconfluentinc:10.6.xfrom
Open
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Dugong (Dugong42)
changed the title
Dugong (Dugong42)
changed the title
Dugong (Dugong42)
force-pushed
the
feat/reduce-cached-connection-logging
branch
from
ff52855 to
8f5f5d9
Compare
Dugong (Dugong42)
force-pushed
the
feat/reduce-cached-connection-logging
branch
from
8f5f5d9 to
23ecb52
Compare
Dugong (Dugong42)
force-pushed
the
feat/reduce-cached-connection-logging
branch
from
23ecb52 to
b13021c
Compare
Author
|
As it is recommended to back-port fixes to earlier branches, I'm submitting this change to the 10.6 branch. |
Author
|
Hi, any chance for a review ? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Connectors produce too many (100+/s) repetitive connection logs when querying a large number of rows.
A message is logged by the CachedConnectionProvider for each fetching of rows regardless of whether a new connection is created or the existing connection is used:
See #1493
Solution
The repetitive log has been moved to the CachedConnectionProvider.newConnection() method to only record new connections.
Access to the CachedConnectionProvider is logged as DEBUG when an existing Connection is used.