Open
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new CI block to trigger the connector jar tests via a sem-trigger command when a pull request is raised, ensuring end‐to‐end validation of connector changes.
- Added a new CI gating block ("Connector Jar Build CI Gating") in the semaphore configuration.
- Incorporated a sem-trigger command to invoke the Connect Jar KDP Test Task using specified parameters.
Comments suppressed due to low confidence (1)
.semaphore/semaphore.yml:92
- [nitpick] The trailing semicolon in the sem-trigger command may be unnecessary and could affect the shell command execution; please verify if it is required.
-w; \
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Developer want to test his changes in the connector against KDP test cases. This makes a good pr gating option to ensure nothing is breaking end to end from a particular dev change.
Solution
A separate task has been created which gets trigger from sem trigger to run the mapped KDP test cases for the connector changes.
Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing done:
Release Plan