Skip to content

Remove doLog in ConfigDef#1604

Open
KGaneshDatta wants to merge 1 commit intomasterfrom
kdatta_log_test
Open

Remove doLog in ConfigDef#1604
KGaneshDatta wants to merge 1 commit intomasterfrom
kdatta_log_test

Conversation

@KGaneshDatta
Copy link
Contributor

Problem

Solution

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@KGaneshDatta KGaneshDatta requested a review from a team as a code owner January 28, 2026 15:16
Copilot AI review requested due to automatic review settings January 28, 2026 15:16
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the shouldLog(props) parameter from the super() constructor calls in JdbcSourceConnectorConfig, simplifying the initialization by relying on the default logging behavior of the parent class.

Changes:

  • Removed the shouldLog(props) parameter from two constructor calls to the parent class

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqube-confluent
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants