CC-38740: Validate column mapping regexes against table.include.list entries#1608
Open
KGaneshDatta wants to merge 2 commits into10.9.xfrom
Open
CC-38740: Validate column mapping regexes against table.include.list entries#1608KGaneshDatta wants to merge 2 commits into10.9.xfrom
KGaneshDatta wants to merge 2 commits into10.9.xfrom
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem
A misconfigured regex in
timestamp.columns.mapping(orincrementing.column.mapping) that doesn't match the tables intable.include.listis only caught at runtime, causing the connector to fail after startup. This error requires to be validated before so that the user can react upon it immediately.Solution
Added config validation in
JdbcSourceConnectorValidationthat verifies eachtable.include.listentry matches exactly one regex in the column mapping configs. Differences are now shown as clear actionable validation errors before the connector starts.Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing done:
Release Plan