[DO NOT MERGE] Ksql image poc 80 #196
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (6)
- cp-ksqldb-server/Dockerfile.ubi8: Language not supported
- cp-ksqldb-server/include/etc/confluent/docker/configure: Language not supported
- cp-ksqldb-server/include/etc/confluent/docker/connect-propertiesSpec.json: Language not supported
- cp-ksqldb-server/include/etc/confluent/docker/ensure: Language not supported
- cp-ksqldb-server/include/etc/confluent/docker/ksqldb-server-propertiesSpec.json: Language not supported
- pom.xml: Language not supported
Comments suppressed due to low confidence (2)
cp-ksqldb-server/test/test_ksql_server.py:62
- The subprocess.run call uses capture_output=True and text=True, but the decode() method call was removed. This might affect the output handling if the output is expected to be a string.
return subprocess.run(cmd, env=os.environ, check=True, capture_output=True, shell=True, text=True)
cp-ksqldb-server/test/test_ksql_server.py:101
- The timeout parameter in the retry function call was changed from 600 to 20. This might cause the test to fail if the server takes longer to start. Please confirm if this change is intentional.
retry(client.info, timeout=20)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Analysis Details5 Issues
Coverage and Duplications
Project ID: ksql-images |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.