Skip to content

feat(testing tool): add DEFINE/UNDEFINE statement support for ksqldb-testing-tool#10738

Open
kancko wants to merge 1 commit intoconfluentinc:masterfrom
kancko:feature-9720
Open

feat(testing tool): add DEFINE/UNDEFINE statement support for ksqldb-testing-tool#10738
kancko wants to merge 1 commit intoconfluentinc:masterfrom
kancko:feature-9720

Conversation

@kancko
Copy link
Copy Markdown

@kancko kancko commented Apr 24, 2025

Description

This changes allow define/undefine variables in test SQL files using DEFINE / UNDEFINE statement. It could be helpful in various cases, for example: when test sql file reuses main sql file (which relay on variables) via RUN SCRIPT.

Fixes: #9720

Testing done

Integration test cases were added under SqlTestingToolTest.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

@kancko kancko requested review from a team and Jim Galasyn (JimGalasyn) as code owners April 24, 2025 09:50
@confluent-cla-assistant
Copy link
Copy Markdown

confluent-cla-assistant bot commented Apr 24, 2025

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ kancko
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link
Copy Markdown
Member

@JimGalasyn Jim Galasyn (JimGalasyn) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using Define Statements in Ksql Test Runner

2 participants