Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces CI pipeline optimizations by modifying Semaphore configuration to improve build queue management and resource utilization.
- Excludes the
pipeline-optbranch from parallel processing restrictions - Adds auto-cancellation of queued builds specifically for the master branch
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.semaphore/semaphore.yml
Outdated
|
|
||
| queue: | ||
| - when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x'" | ||
| - when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x' and branch != 'pipeline-opt'" |
There was a problem hiding this comment.
Hardcoding the branch name 'pipeline-opt' in the CI configuration creates a maintenance burden. Consider using a more generic pattern or environment variable to avoid needing to update the CI config for each optimization branch.
| - when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x' and branch != 'pipeline-opt'" | |
| - when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x' and branch !~ 'pipeline-opt.*'" |
.semaphore/semaphore.yml
Outdated
|
|
||
| auto_cancel: | ||
| queued: | ||
| when: "branch == 'master'" |
There was a problem hiding this comment.
Auto-cancelling queued builds only on the master branch may not be the intended behavior. Typically, auto-cancellation is more useful for feature branches to avoid running outdated builds when new commits are pushed. Consider if this should apply to all branches or if the logic should be inverted.
| when: "branch == 'master'" | |
| when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x' and branch != 'pipeline-opt'" |
Description
What behavior do you want to change, why, how does your patch achieve the changes?
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist