[DO NOT MERGE] test updated docker compose#165
Open
Hrithik Kulkarni (hk10111) wants to merge 1 commit intomasterfrom
Open
[DO NOT MERGE] test updated docker compose#165Hrithik Kulkarni (hk10111) wants to merge 1 commit intomasterfrom
Hrithik Kulkarni (hk10111) wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily modifies the Docker upstream tag configuration in the CI/CD pipeline for testing purposes. The change hardcodes a specific Docker image tag instead of using the dynamic latest tag.
- Replaces dynamic
$LATEST_TAGvariable with hardcoded tagdev-7.4.x-8fa813ee
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - export DOCKER_UPSTREAM_REGISTRY=$DOCKER_PROD_REGISTRY | ||
| - export LATEST_TAG=$BRANCH_TAG-latest | ||
| - export DOCKER_UPSTREAM_TAG="$LATEST_TAG" | ||
| - export DOCKER_UPSTREAM_TAG="dev-7.4.x-8fa813ee" |
There was a problem hiding this comment.
The Docker upstream tag is hardcoded to a specific version. Since this is marked as '[DO NOT MERGE]', ensure this change is reverted before merging. Consider using a feature flag or environment variable if temporary testing configurations are needed in the future.
Suggested change
| - export DOCKER_UPSTREAM_TAG="dev-7.4.x-8fa813ee" | |
| - export DOCKER_UPSTREAM_TAG="${DOCKER_UPSTREAM_TAG:-dev-7.4.x-8fa813ee}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.