Skip to content

#minor: update Flink statement example#758

Open
Jim Galasyn (JimGalasyn) wants to merge 1 commit intomasterfrom
docs-34166
Open

#minor: update Flink statement example#758
Jim Galasyn (JimGalasyn) wants to merge 1 commit intomasterfrom
docs-34166

Conversation

@JimGalasyn
Copy link
Member

Release Notes

New Features

  • [Briefly describe new features introduced in this PR].

Bug Fixes

  • [Briefly describe any bugs fixed in this PR].

Examples

  • [Briefly describe any Terraform configuration example updates in this PR].

Checklist

  • I can successfully build and use a custom Terraform provider binary for Confluent.
  • I have verified my PR with real Confluent Cloud resources in a pre-prod or production environment, or both.
  • I have attached manual Terraform verification results or screenshots in the Test & Review section below.
  • I have included appropriate Terraform acceptance or unit tests for any new resource, data source, or functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have updated the corresponding documentation and include relevant examples for this PR.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Check this box if the feature is enabled for certain organizations only

What

Update the code example for the confluent_flink_statement resource to use a connection instead of the deprecated sql.secrets.openaikey property.

Blast Radius

References

Test & Review

@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (79.90% Estimated after merge)
  • Duplications No duplication information (0.00% Estimated after merge)

Project ID: terraform-provider-confluent

View in SonarQube

Copy link
Contributor

@linouk23 Kostya Linou (linouk23) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jim Galasyn (@JimGalasyn), could you attach some kind of test results to the PR description when you have a moment? It's a bit surprising that it still works without any OpenAI credentials.

@JimGalasyn
Copy link
Member Author

Jim Galasyn (@JimGalasyn), could you attach some kind of test results to the PR description when you have a moment? It's a bit surprising that it still works without any OpenAI credentials.

Kostya Linou (@linouk23) Right, now it requires openai-cli-connection as a confluent_flink_connection resource with the Open AI endpoint and auth details. Not sure about the best way to realize this in the configuration file example. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants