Skip to content

Flip make.enable from true to false#814

Open
Steven Gagniere (sgagniere) wants to merge 1 commit intomasterfrom
make-enable-false
Open

Flip make.enable from true to false#814
Steven Gagniere (sgagniere) wants to merge 1 commit intomasterfrom
make-enable-false

Conversation

@sgagniere
Copy link
Member

Release Notes

New Features

  • [Briefly describe new features introduced in this PR].

Bug Fixes

  • [Briefly describe any bugs fixed in this PR].

Examples

  • [Briefly describe any Terraform configuration example updates in this PR].

Checklist

  • I can successfully build and use a custom Terraform provider binary for Confluent.
  • I have verified my PR with real Confluent Cloud resources in a pre-prod or production environment, or both.
  • I have attached manual Terraform verification results or screenshots in the Test & Review section below.
  • I have included appropriate Terraform acceptance or unit tests for any new resource, data source, or functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have updated the corresponding documentation and include relevant examples for this PR.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Check this box if the feature is enabled for certain organizations only

What

This should not be enabled for public repos.

Blast Radius

References

Test & Review

Copilot AI review requested due to automatic review settings September 12, 2025 19:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables the make functionality in the service configuration by changing the enable flag from true to false. This appears to be a configuration change to prevent make operations from running, likely for security or operational reasons in public repositories.

  • Changed the make.enable setting from true to false in service configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (79.90% Estimated after merge)
  • Duplications No duplication information (0.00% Estimated after merge)

Project ID: terraform-provider-confluent

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants