Skip to content

[APIE-571] - update for default compute pool#855

Open
tmalik (tmalikconfluent) wants to merge 6 commits intomasterfrom
APIE-571
Open

[APIE-571] - update for default compute pool#855
tmalik (tmalikconfluent) wants to merge 6 commits intomasterfrom
APIE-571

Conversation

@tmalikconfluent
Copy link
Contributor

@tmalikconfluent tmalik (tmalikconfluent) commented Oct 8, 2025

Release Notes

New Features

  • Add support for flink default compute pool

Bug Fixes

  • [Briefly describe any bugs fixed in this PR].

Examples

  • [Briefly describe any Terraform configuration example updates in this PR].

Checklist

  • I can successfully build and use a custom Terraform provider binary for Confluent.
  • I have verified my PR with real Confluent Cloud resources in a pre-prod or production environment, or both.
  • I have attached manual Terraform verification results or screenshots in the Test & Review section below.
  • I have included appropriate Terraform acceptance or unit tests for any new resource, data source, or functionality.
  • I have included appropriate Terraform live testing for any new resource, data source, or functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have updated the corresponding documentation and include relevant examples for this PR.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Check this box if the feature is enabled for certain organizations only

What

This will allow user to submit statement without an explicitly specified compute pool (CP). Instead, backend will provision a “default” compute pool (DCP) that is created and managed on the user’s behalf.

Blast Radius

Flink statement create and flink compute pool commands could be affected for existing as well as new behaviour.

References

https://confluentinc.atlassian.net/browse/APIE-571

Test & Review

Added extensive integration and live tests.
Manual testing link: https://confluent.slack.com/archives/C08H9NWM0TG/p1762189642781129

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent
Copy link

Failed

  • 56.30% Coverage on New Code (is less than 80.00%)

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage 56.30% Coverage (79.80% Estimated after merge)
  • Duplications No duplication information (0.20% Estimated after merge)

Project ID: terraform-provider-confluent

View in SonarQube

@tmalikconfluent tmalik (tmalikconfluent) marked this pull request as ready for review November 4, 2025 20:58
@tmalikconfluent tmalik (tmalikconfluent) requested a review from a team as a code owner November 4, 2025 20:58
Copilot AI review requested due to automatic review settings November 4, 2025 20:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Flink default compute pools, allowing users to submit Flink statements without explicitly specifying a compute pool. The backend will provision a default compute pool managed on behalf of the user.

Key changes:

  • Introduced confluent_flink_compute_pool_config resource and data source for managing default compute pool configuration
  • Added default_pool attribute to confluent_flink_compute_pool resource and data source
  • Made flink_compute_pool_id optional in provider configuration, reducing required attributes from 7 to 6 (non-OAuth) and 5 to 4 (OAuth)

Reviewed Changes

Copilot reviewed 26 out of 27 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
internal/provider/resource_flink_compute_pool_config.go New resource implementation for managing default compute pool configuration
internal/provider/data_source_flink_compute_pool_config.go New data source for reading compute pool configuration
internal/provider/resource_flink_compute_pool.go Added default_pool attribute support
internal/provider/resource_flink_statement.go Made compute pool ID optional for statement creation
internal/provider/utils.go Updated validation to remove flink_compute_pool_id requirement
internal/provider/provider.go Registered new resource and data source
go.mod Updated Go version and SDK dependencies
Test files Added comprehensive test coverage for new functionality
Documentation files Added documentation for new resource and data source

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants