[APIE-571] - update for default compute pool#855
Open
tmalik (tmalikconfluent) wants to merge 6 commits intomasterfrom
Open
[APIE-571] - update for default compute pool#855tmalik (tmalikconfluent) wants to merge 6 commits intomasterfrom
tmalik (tmalikconfluent) wants to merge 6 commits intomasterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
d436699 to
275e181
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Flink default compute pools, allowing users to submit Flink statements without explicitly specifying a compute pool. The backend will provision a default compute pool managed on behalf of the user.
Key changes:
- Introduced
confluent_flink_compute_pool_configresource and data source for managing default compute pool configuration - Added
default_poolattribute toconfluent_flink_compute_poolresource and data source - Made
flink_compute_pool_idoptional in provider configuration, reducing required attributes from 7 to 6 (non-OAuth) and 5 to 4 (OAuth)
Reviewed Changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
internal/provider/resource_flink_compute_pool_config.go |
New resource implementation for managing default compute pool configuration |
internal/provider/data_source_flink_compute_pool_config.go |
New data source for reading compute pool configuration |
internal/provider/resource_flink_compute_pool.go |
Added default_pool attribute support |
internal/provider/resource_flink_statement.go |
Made compute pool ID optional for statement creation |
internal/provider/utils.go |
Updated validation to remove flink_compute_pool_id requirement |
internal/provider/provider.go |
Registered new resource and data source |
go.mod |
Updated Go version and SDK dependencies |
| Test files | Added comprehensive test coverage for new functionality |
| Documentation files | Added documentation for new resource and data source |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6af2bf3 to
4817444
Compare
4817444 to
473dfeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
New Features
Bug Fixes
Examples
Checklist
Test & Reviewsection below.Blast Radiussection below.What
This will allow user to submit statement without an explicitly specified compute pool (CP). Instead, backend will provision a “default” compute pool (DCP) that is created and managed on the user’s behalf.
Blast Radius
Flink statement create and flink compute pool commands could be affected for existing as well as new behaviour.
References
https://confluentinc.atlassian.net/browse/APIE-571
Test & Review
Added extensive integration and live tests.
Manual testing link: https://confluent.slack.com/archives/C08H9NWM0TG/p1762189642781129