Skip to content

[APIE-654] Add Unity Catalog support and fix an error in the catalog data source for Snowflake catalogs#884

Open
Steven Gagniere (sgagniere) wants to merge 1 commit intomasterfrom
apie-654
Open

[APIE-654] Add Unity Catalog support and fix an error in the catalog data source for Snowflake catalogs#884
Steven Gagniere (sgagniere) wants to merge 1 commit intomasterfrom
apie-654

Conversation

@sgagniere
Copy link
Member

@sgagniere Steven Gagniere (sgagniere) commented Nov 11, 2025

Release Notes

New Features

  • Added support for a new optional unity configuration block to confluent_catalog_integration resource and data-source in a General Availability lifecycle stage.

Bug Fixes

  • Fixed an issue where the confluent_catalog_integration data-source could not read Snowflake catalog integrations.

Examples

  • [Briefly describe any Terraform configuration example updates in this PR].

Checklist

  • I can successfully build and use a custom Terraform provider binary for Confluent.
  • I have verified my PR with real Confluent Cloud resources in a pre-prod or production environment, or both.
  • I have attached manual Terraform verification results or screenshots in the Test & Review section below.
  • I have included appropriate Terraform acceptance or unit tests for any new resource, data source, or functionality.
  • I have included appropriate Terraform live testing for any new resource, data source, or functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have updated the corresponding documentation and include relevant examples for this PR.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Check this box if the feature is enabled for certain organizations only

What

  • Add support for Unity catalog integrations.
  • Also fix a bug where the data source could not read Snowflake catalog integrations.
    • The cause of the bug was that the data source recycled the attribute setting function from the resource, but the resource has sensitive client_id and client_secret fields under the snowflake block while the data source does not, resulting in the following error:
Error: Invalid address to set: []string{"snowflake", "0", "client_id"}

Blast Radius

Customers managing AWS Glue or Snowflake catalog integrations may be affected in case of bugs in the implementation.

References

Test & Review

https://docs.google.com/document/d/1IxtcOvDHUazqV5CBluEQFfUq1mLp7lqrAhxwLPZQqHE/edit?usp=sharing

… panic in the data source for snowflake catalogs
@sgagniere Steven Gagniere (sgagniere) marked this pull request as ready for review November 15, 2025 02:24
@sgagniere Steven Gagniere (sgagniere) requested a review from a team as a code owner November 15, 2025 02:24
Copilot AI review requested due to automatic review settings November 15, 2025 02:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Unity Catalog integrations to the Confluent Terraform provider and fixes a bug preventing Snowflake catalog integrations from being read via data sources.

Key Changes:

  • Added Unity Catalog configuration block to confluent_catalog_integration resource and data source
  • Fixed data source read error for Snowflake integrations by conditionally setting sensitive fields
  • Added comprehensive test coverage for Unity Catalog integrations

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/testdata/catalog_integration/create_unity_ci.json Test fixture for Unity Catalog integration creation
internal/testdata/catalog_integration/read_created_unity_ci.json Test fixture for reading created Unity Catalog integration
internal/testdata/catalog_integration/update_unity_ci.json Test fixture for Unity Catalog integration updates
internal/provider/resource_catalog_integration_test.go Added acceptance tests for Unity Catalog integration lifecycle
internal/provider/resource_catalog_integration.go Implemented Unity Catalog schema, create/update/read logic with conditional sensitive field handling
internal/provider/data_source_catalog_integration_test.go Added data source tests for Snowflake and Unity Catalog integrations
internal/provider/data_source_catalog_integration.go Added Unity Catalog schema to data source
docs/resources/confluent_tableflow_topic.md Updated documentation to mention Unity Catalog support
docs/resources/confluent_catalog_integration.md Added Unity Catalog configuration documentation
docs/data-sources/confluent_catalog_integration.md Added Unity Catalog attributes documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Computed: true,
}
}

Copy link

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unityDataSourceSchema function is missing a documentation comment explaining its purpose, similar to how other schema functions in the file have descriptive comments.

Suggested change
// unityDataSourceSchema returns the schema definition for the Unity Catalog integration
// data source, including fields for the Databricks workspace endpoint and catalog name.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants