[APIE-654] Add Unity Catalog support and fix an error in the catalog data source for Snowflake catalogs#884
Open
Steven Gagniere (sgagniere) wants to merge 1 commit intomasterfrom
Open
[APIE-654] Add Unity Catalog support and fix an error in the catalog data source for Snowflake catalogs#884Steven Gagniere (sgagniere) wants to merge 1 commit intomasterfrom
Steven Gagniere (sgagniere) wants to merge 1 commit intomasterfrom
Conversation
… panic in the data source for snowflake catalogs
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Unity Catalog integrations to the Confluent Terraform provider and fixes a bug preventing Snowflake catalog integrations from being read via data sources.
Key Changes:
- Added Unity Catalog configuration block to
confluent_catalog_integrationresource and data source - Fixed data source read error for Snowflake integrations by conditionally setting sensitive fields
- Added comprehensive test coverage for Unity Catalog integrations
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
internal/testdata/catalog_integration/create_unity_ci.json |
Test fixture for Unity Catalog integration creation |
internal/testdata/catalog_integration/read_created_unity_ci.json |
Test fixture for reading created Unity Catalog integration |
internal/testdata/catalog_integration/update_unity_ci.json |
Test fixture for Unity Catalog integration updates |
internal/provider/resource_catalog_integration_test.go |
Added acceptance tests for Unity Catalog integration lifecycle |
internal/provider/resource_catalog_integration.go |
Implemented Unity Catalog schema, create/update/read logic with conditional sensitive field handling |
internal/provider/data_source_catalog_integration_test.go |
Added data source tests for Snowflake and Unity Catalog integrations |
internal/provider/data_source_catalog_integration.go |
Added Unity Catalog schema to data source |
docs/resources/confluent_tableflow_topic.md |
Updated documentation to mention Unity Catalog support |
docs/resources/confluent_catalog_integration.md |
Added Unity Catalog configuration documentation |
docs/data-sources/confluent_catalog_integration.md |
Added Unity Catalog attributes documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Computed: true, | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
The unityDataSourceSchema function is missing a documentation comment explaining its purpose, similar to how other schema functions in the file have descriptive comments.
Suggested change
| // unityDataSourceSchema returns the schema definition for the Unity Catalog integration | |
| // data source, including fields for the Databricks workspace endpoint and catalog name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
New Features
unityconfiguration block toconfluent_catalog_integrationresource and data-source in a General Availability lifecycle stage.Bug Fixes
confluent_catalog_integrationdata-source could not read Snowflake catalog integrations.Examples
Checklist
Test & Reviewsection below.Blast Radiussection below.What
client_idandclient_secretfields under thesnowflakeblock while the data source does not, resulting in the following error:Blast Radius
Customers managing AWS Glue or Snowflake catalog integrations may be affected in case of bugs in the implementation.
References
Test & Review
https://docs.google.com/document/d/1IxtcOvDHUazqV5CBluEQFfUq1mLp7lqrAhxwLPZQqHE/edit?usp=sharing