APIE-813: Add GCP support for connect artifact resource#950
Open
Himanshu Singla (hisingla12) wants to merge 1 commit intomasterfrom
Open
APIE-813: Add GCP support for connect artifact resource#950Himanshu Singla (hisingla12) wants to merge 1 commit intomasterfrom
Himanshu Singla (hisingla12) wants to merge 1 commit intomasterfrom
Conversation
- Add GCP static test and test data files - Add GCP live test (TestAccConnectArtifactGCPLive) - Update docs to include GCP as accepted cloud provider value Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot started reviewing on behalf of
Himanshu Singla (hisingla12)
February 28, 2026 08:58
View session
Himanshu Singla (hisingla12)
changed the title
There was a problem hiding this comment.
Pull request overview
Adds Google Cloud Platform (GCP) coverage for the confluent_connect_artifact resource by introducing Wiremock test fixtures + a new acceptance test, and updating user documentation to list GCP as an allowed cloud value.
Changes:
- Added GCP Wiremock test data (presigned URL + create/read responses) for connect artifact lifecycle tests.
- Added a new Wiremock-based GCP acceptance test and a new live acceptance test
TestAccConnectArtifactGCPLive. - Updated resource and data source docs to include
GCPas an acceptedcloudvalue.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/testdata/connect_artifact/read_presigned_url_gcp.json | Adds GCP presigned upload URL fixture for tests. |
| internal/testdata/connect_artifact/read_created_artifact_gcp.json | Adds GCP “READY” read-response fixture for tests. |
| internal/testdata/connect_artifact/create_artifact_gcp.json | Adds GCP “PROCESSING” create-response fixture for provisioning flow tests. |
| internal/provider/resource_connect_artifact_live_test.go | Adds GCP live acceptance test coverage. |
| internal/provider/resource_connect_artifact_gcp_test.go | Adds Wiremock-based GCP acceptance test for resource lifecycle + import. |
| docs/resources/confluent_connect_artifact.md | Documents GCP as an accepted cloud argument value for the resource. |
| docs/data-sources/confluent_connect_artifact.md | Documents GCP as an accepted cloud argument value for the data source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Himanshu Singla (hisingla12)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
New Features
Checklist
Test & Reviewsection below.Blast Radiussection below.What
This PR enables connect artifact (custom SMT) uploads to GCP regions.
Changes:
Added GCP tests for connect artifacts:
resource_connect_artifact_gcp_test.goTestAccConnectArtifactGCPLiveUpdated documentation to include
GCPas an accepted cloud provider value:docs/data-sources/confluent_connect_artifact.mddocs/resources/confluent_connect_artifact.mdWhy:
Blast Radius
Low risk - No changes to upload logic. GCP upload uses the same presigned URL flow as AWS.
Potential Impact:
References
https://confluentinc.atlassian.net/browse/APIE-813
Test & Review
All unit and acceptance tests pass for AWS, Azure, and GCP.
Artifact Upload (Staging)
cloud = "GCP",cloud = "AWS",cloud = "AZURE"Unit Test Results
TestAccConnectArtifactGCP- PASSLive Test Results (Staging)
https://api.stag.cpdev.cloud) withCONFLUENT_CLOUD_ENVIRONMENT_ID=env-stgconzx9p