Skip to content

Define custom order of messages #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexeyraspopov wants to merge 2 commits into from
Closed

Define custom order of messages #1156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eb7e86
define custom order of messages
alexeyraspopov Mar 7, 2025
e0cc541
desc by offset within the same partition, otherwise rely on timestamp
alexeyraspopov Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/consume.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,17 +687,13 @@ function messageViewerStartPollingCommand(
case "PreviewJSON": {
track({ action: "preview-snapshot" });
const {
timestamp,
order,
messages: { values },
serialized,
} = stream();
const includes = bitset()?.predicate() ?? (() => true);
const records: string[] = [];
for (
let i = 0, p = timestamp.head, payload;
i < timestamp.size;
i++, p = timestamp.next[p]
) {
for (let i = 0, p = order.head, payload; i < order.size; i++, p = order.next[p]) {
if (includes(p)) {
payload = prepare(values[p], serialized.key.includes(p), serialized.value.includes(p));
records.push("\t" + JSON.stringify(payload));
Expand Down
18 changes: 14 additions & 4 deletions src/stream/stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export class Stream {
serialized: { key: BitSet; value: BitSet };
timestamp: SkipList<number | undefined>;
partition: SkipList<number | undefined>;
order: SkipList<PartitionConsumeRecord> | null;
order: SkipList<PartitionConsumeRecord>;

constructor(capacity = 2 ** 24) {
this.capacity = capacity;
Expand Down Expand Up @@ -35,7 +35,17 @@ export class Stream {
let partitionOf = (point: number) => values[point].partition_id;
this.partition = new SkipList(capacity, 1 / 2, partitionOf, ascending);

this.order = null;
/* Messages are ordered by timestamp, partition, offset in descending order. */
this.order = new SkipList(
capacity,
1 / 4,
(point: number) => values[point],
(a, b) => {
return a.partition_id === b.partition_id
? descending(a.offset, b.offset)
: descending(a.timestamp, b.timestamp);
},
);
}

insert(message: PartitionConsumeRecord) {
Expand All @@ -46,9 +56,11 @@ export class Stream {
if (isCircular) {
this.timestamp.remove(index);
this.partition.remove(index);
this.order.remove(index);
}
this.timestamp.insert(index);
this.partition.insert(index);
this.order.insert(index);

/* TEMP the API can provide key/value as objects which we don't really
utilize as such right now. For faster search and table's rendering time
Expand All @@ -62,8 +74,6 @@ export class Stream {
this.serialized.value.set(index);
} else this.serialized.value.unset(index);

// TEMP (July 12th) disabling this since we don't have sorting feature yet
// this.order?.insert(index);
return index;
}

Expand Down