Skip to content

Conversation

@noeldevelops
Copy link
Member

Summary of Changes

  • The .grid-cell mark theme color style is now in uikit.css instead of flink-statement-results.html, so it will apply to message viewer and any future grid-cells we write.
  • ❓ Attempt to prevent the mark color showing when text is truncated, using an overflow:clip rule.

Click-testing instructions

  1. Try searching in both topic message viewer and flink statement results to verify the highlight color matches your theme(s).

Optional: Any additional details or context that should be provided?

Topic Highlighting AFTER:
topic-highlight

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests

  • Added new
  • Updated existing
  • Deleted existing

Release notes

  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants