E2E: remove dedicated teardown for LOCAL connections, and allow containers to preexist on startup#3363
Open
Dave Shoup (shouples) wants to merge 2 commits intomainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Playwright E2E connection fixtures to stop explicitly tearing down LOCAL containers after each test, and instead reuse already-running local containers to make @local test runs more flexible (closes #2951).
Changes:
- Make
setupLocalConnection()idempotent by detecting preexistingLOCALcontainers and only starting what’s missing (Kafka always, Schema Registry optionally). - Remove
teardownLocalConnection()and simplify theconnectionItemfixture teardown logic to do nothing for all connection types.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/e2e/utils/connections.ts |
Adjusts local-connection setup logic to reuse preexisting local containers; removes dedicated local teardown helper. |
tests/e2e/baseTest.ts |
Removes per-test teardown switch and relies on idempotent setup + existing extension shutdown behavior. |
airlock-confluentinc
Bot
force-pushed
the
djs/e2e-harden-local-connection-fixture
branch
from
4d77489 to
db954a9
Compare
airlock-confluentinc
Bot
force-pushed
the
djs/e2e-harden-local-connection-fixture
branch
from
db954a9 to
5aeaa51
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Removes the hard requirement that each
@local-tagged test needs to handle the full container lifecycle during fixture setup and teardown.Now we only assert that the Kafka container (and optionally SR container) is available during setup (whether started externally / by another test or the current test) and skips teardown entirely*.
*Maybe we want to add a single after-all hook to try local teardown in a future branch, but isn't necessary here.
Closes #2951
@local-tagged tests' timingClick-testing instructions
@local-tagged tests via:@localtest run times should be significantly reducedPull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Release notes