fix(E2E): wait for notification/sidebar in Flink artifact setup#3375
Draft
Dave Shoup (shouples) wants to merge 4 commits intomainfrom
Draft
fix(E2E): wait for notification/sidebar in Flink artifact setup#3375Dave Shoup (shouples) wants to merge 4 commits intomainfrom
Dave Shoup (shouples) wants to merge 4 commits intomainfrom
Conversation
…ock on UI element presence before command palette invocation
There was a problem hiding this comment.
Pull request overview
This PR improves Playwright E2E stability for Flink artifact setup by adding a shared “workspace/window is ready” preparation step that runs before interacting with VS Code UI (e.g., command palette) after workspace transitions.
Changes:
- Add
prepareTestWorkspace()helper to wait for workbench readiness, dismiss the disabled-extensions toast, and collapse the secondary sidebar. - Move
openConfluentSidebar()utility into the newutils/workspace.tsmodule and update imports. - Use
prepareTestWorkspace()in the Flink artifacts spec and global E2EbeforeEachsetup.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/e2e/utils/workspace.ts |
Introduces prepareTestWorkspace() and hosts openConfluentSidebar() for shared workspace/window readiness + sidebar activation helpers. |
tests/e2e/utils/sidebarNavigation.ts |
Removes the old module after relocating openConfluentSidebar() to workspace.ts. |
tests/e2e/utils/connections.ts |
Updates import to the new openConfluentSidebar() location. |
tests/e2e/specs/flinkArtifact.spec.ts |
Replaces ad-hoc waits after openFolder with prepareTestWorkspace(). |
tests/e2e/specs/confluent.spec.ts |
Updates import to the new openConfluentSidebar() location. |
tests/e2e/baseTest.ts |
Uses prepareTestWorkspace() in global setup instead of inline toast/sidebar handling. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Unfortunately delayed follow-up to #3365 since it was missing a critical step: we needed to wait for some of the initial "workspace/window loaded" locators to be available before any interactions could take place (like invoking the command palette).
Recent failures show that command invocation happened while the (new) workspace window was still loading, resulting in a failed assertion waiting for the quick input box:
The new behavior is bundled into a new
prepareTestWorkspace()function that includes:electronAppsetup)pagesetup, now moved into its own function)Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Release notes