-
Notifications
You must be signed in to change notification settings - Fork 43
Change git branch check from source to target #1545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
As Konflux RPM builds have evolved, it is apparent that we want the check to be against target branches, not source. Source branches are arbitrarily named JIRA: ROK-923
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
I checked an attestation and I see that we get the branch in different formats. Example:
Will the matching still work if you just get branch name "main" instead of the full git ref? |
Update docs to refer to target branch, change the release data key to allowed_target_branch_patterns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Are you happy to merge, or do you want to wait for the data change PR to merge first?
I'm going to add a test for one more branch pattern to add to the release data. If that passes, I'll merge the release data first then this one. |
As Konflux RPM builds have evolved, it is apparent that we want the check to be against target branches, not source. Source branches are arbitrarily named
JIRA: ROK-923