Skip to content

Conversation

@jorris
Copy link
Contributor

@jorris jorris commented Oct 7, 2025

As Konflux RPM builds have evolved, it is apparent that we want the check to be against target branches, not source. Source branches are arbitrarily named

JIRA: ROK-923

As Konflux RPM builds have evolved, it is apparent that we want the
check to be against target branches, not source. Source branches are
arbitrarily named

JIRA: ROK-923
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
policy/release/git_branch/git_branch.rego 100.00% <100.00%> (ø)
policy/release/git_branch/git_branch_test.rego 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simonbaird
Copy link
Member

simonbaird commented Oct 7, 2025

I checked an attestation and I see that we get the branch in different formats.

Example:

  • "build.appstudio.redhat.com/target_branch": "main"
  • "pipelinesascode.tekton.dev/source-branch": "refs/heads/main"

Will the matching still work if you just get branch name "main" instead of the full git ref?

Update docs to refer to target branch, change the release
data key to allowed_target_branch_patterns
@github-actions github-actions bot added size: S and removed size: XS labels Oct 7, 2025
Copy link
Member

@simonbaird simonbaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Are you happy to merge, or do you want to wait for the data change PR to merge first?

@jorris
Copy link
Contributor Author

jorris commented Oct 21, 2025

Lgtm. Are you happy to merge, or do you want to wait for the data change PR to merge first?

I'm going to add a test for one more branch pattern to add to the release data. If that passes, I'll merge the release data first then this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants