-
Notifications
You must be signed in to change notification settings - Fork 138
feat(handler): Implement per-method timeouts with proto extensions #909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huyquanha
wants to merge
9
commits into
connectrpc:main
Choose a base branch
from
huyquanha:add_custom_handler_timeouts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4a7c56e
add proto extension to customise timeouts, plus updating buf files
huyquanha b72e80f
revert a lot of the redundancy changes
huyquanha 7e9eee0
give back newlines
huyquanha 8ea1903
newline
huyquanha d7395ed
newline
huyquanha ec935af
fix lint errors
huyquanha e7c7c6b
finish tests
huyquanha 83489cd
update comments
huyquanha 7e0adc1
Apply suggestion from @huyquanha
huyquanha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| version: v2 | ||
| plugins: | ||
| - local: protoc-gen-go | ||
| out: gen | ||
| opt: paths=source_relative | ||
| # Currently, buf doesn't support per-module generation config, which | ||
| # is required to run a different set of plugins/plugin options for | ||
| # the testdata modules. As a workaround, we use `inputs` to restrict | ||
| # the generation config in this file to only the "proto" module, and | ||
| # have separate buf.gen.yaml files for the testdata modules. | ||
| # See: https://github.com/bufbuild/buf/issues/3060 | ||
| inputs: | ||
| - directory: proto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| version: v2 | ||
| modules: | ||
| - path: proto | ||
| # this must be declared as a module in the same workspace as "proto", | ||
| # so it can import symbols from annotations.proto. | ||
| - path: internal/testdata/methodtimeouts | ||
| lint: | ||
| use: | ||
| - STANDARD | ||
| disallow_comment_ignores: true | ||
| breaking: | ||
| use: | ||
| - WIRE_JSON | ||
102 changes: 102 additions & 0 deletions
102
cmd/protoc-gen-connect-go/gen/connectrpc/go/options/v1/annotations.pb.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
150 changes: 150 additions & 0 deletions
150
cmd/protoc-gen-connect-go/gen/connectrpc/go/options/v1/connect.pb.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
9 changes: 9 additions & 0 deletions
9
cmd/protoc-gen-connect-go/internal/testdata/methodtimeouts/buf.gen.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| version: v2 | ||
| plugins: | ||
| - local: protoc-gen-go | ||
| out: gen | ||
| opt: paths=source_relative | ||
| - local: protoc-gen-connect-go | ||
| out: gen | ||
| opt: paths=source_relative | ||
| clean: true |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
presumably we could also add all the other
testdatamodules here too, but it's not strictly required right now.