Clarify concurrent use semantics for streaming types#911
Open
emcfarlane wants to merge 2 commits intomainfrom
Open
Clarify concurrent use semantics for streaming types#911emcfarlane wants to merge 2 commits intomainfrom
emcfarlane wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Edward McFarlane <emcfarlane@buf.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs for
StreamingHandlerConnincorrectly stated that implementations "do not need to be safe for concurrent use", and theStreamingClientConnmethod group comments used the ambiguous phrase "may race with each other".Replace both with consistent, precise language across all streaming interfaces and high-level stream types: the read side and write side may be used concurrently with each other, but neither side is safe to call concurrently with itself.
Fixes #871, fixes connectrpc/otelconnect-go#194