Repository navigation
Note that grpchealth needs an HTTP/2 server with trailers - #456
Merged
Merged
Conversation
`grpc-health-probe` and Kubernetes gRPC probes speak only the gRPC protocol, so served as the README shows on Uvicorn or Granian they fail: against Uvicorn, `grpc-health-probe` reports `failed to connect service ... within 3s`, and against Granian `health rpc failed` with "ASGI server does not support ASGI trailers extension". Against pyvoy it reports `status: SERVING`. Signed-off-by: Stefan VanBuren <stefan@vanburen.xyz>
stefanvanburen
marked this pull request as ready for review
November 10, 2026 01:04
anuraaga
approved these changes
Nov 10, 2026
Comment on lines
+45
to
+48
| `grpc-health-probe` and Kubernetes gRPC probes speak the gRPC protocol, | ||
| which needs HTTP/2 and the ASGI trailers extension. Serve the app with | ||
| [pyvoy](https://github.com/curioswitch/pyvoy), which supports both; Uvicorn | ||
| (HTTP/1.1 only) and Granian (no trailers) don't. |
Collaborator
There was a problem hiding this comment.
Suggested change
| `grpc-health-probe` and Kubernetes gRPC probes speak the gRPC protocol, | |
| which needs HTTP/2 and the ASGI trailers extension. Serve the app with | |
| [pyvoy](https://github.com/curioswitch/pyvoy), which supports both; Uvicorn | |
| (HTTP/1.1 only) and Granian (no trailers) don't. | |
| Reflection uses the gRPC protocol which requires a server that supports HTTP/2 trailers such as [pyvoy](https://pyvoy.dev). |
Signed-off-by: Stefan VanBuren <stefan@vanburen.xyz>
Signed-off-by: Stefan VanBuren <stefan@vanburen.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same note as #453 but for grpchealth:
grpc-health-probe(and k8s gRPC probes) only speak gRPC, so the README example served on uvicorn or granian just fails. Checked withgrpc-health-probeagainst pyvoy (SERVING), uvicorn (can't connect), and granian (no trailers).