Repository navigation
Apply missed review nits from #454 and #460 - #465
Merged
Merged
Conversation
Spell out that both reflection services appear in `ListServices` even when only one is mounted, so a client calling the unmounted one gets a 404. Applies anuraaga's suggestion from #460 to the README and the `reflection_apps` / `reflection_apps_sync` docstrings. Signed-off-by: Stefan VanBuren <stefan@vanburen.xyz>
Applies anuraaga's #454 review: use a dash rather than a colon in "Why Connect?" (an em dash, matching the rest of the README), and run the unary example with uvicorn, since it doesn't need HTTP/2 and shows Connect works with an existing server. Signed-off-by: Stefan VanBuren <stefan@vanburen.xyz>
anuraaga
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies anuraaga's review suggestions from #460 and #454 that I missed before merging (oops):
reflection_apps/reflection_apps_syncdocstrings and the grpcreflect README now explain why to mount both apps: both services show up inListServiceseven if only one is mounted, so a client that calls the unmounted one gets a 404.-if you'd rather, but I'd prefer to be typographically (grammatically?) correct 😄uvicorn, since it doesn't need HTTP/2 and the point is that you don't need to change your server to adopt Connect.