Refactoring part of argument of periapsis change maneuver workflow, rerunning clang-format, updating test coverage reports #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed, adding some tests To account for varying orbital parameters by the time an argument of periapsis change maneuver is actually implemented (compared to initial orbital elements of the satellite), and to try to streamline the user experience more, the maneuver is simply added to the satellite, where it is stashed in a list of maneuvers that are awaiting initialization. When the satellite's internal clock reaches or first surpasses the start time, it is initialized and removed from that list of maneuvers needing initialization. Also, the calibration method previously implemented utilizing mean values has been removed, as I no longer think it's as useful as I did earlier. Also added a couple tests relating to argument of periapsis change maneuvers.
Manually adjusting some formatting I didn't like
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I wanted to improve the process of adding and implementing an argument of periapsis change maneuver. First, I wanted to account for the fact that due to, e.g., oscillations over time, the orbital elements when the maneuver is initiated might not be the same as the initial orbital elements of the satellite (like when the maneuver is slated to start at some time in the future). I also wanted to streamline the workflow a bit more for the user. Also it'd been a little while since I'd run clang-format on the main files.
Changes
Testing
Needs to pass existing and new tests