Add shared gRPC proto contract for portfolio items - #656
Open
conorheffron with Copilot wants to merge 7 commits into
Open
Add shared gRPC proto contract for portfolio items#656conorheffron with Copilot wants to merge 7 commits into
conorheffron with Copilot wants to merge 7 commits into
Conversation
Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/627d7008-c5c0-4167-b2ec-094d79ec684d Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a contract-only gRPC/protobuf spike for portfolio project data so external modules can generate shared types and later implement the catalog service.
Changes:
- Added a new
portfolio_projects.protocontract with aPortfolioProjectCatalogservice and portfolio item messages. - Documented how external projects can generate Java code from the shared proto contract.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/main/proto/ironoc/portfolio/v1/portfolio_projects.proto |
Defines the initial portfolio gRPC/protobuf contract. |
README.md |
Adds documentation for locating and generating code from the proto spike. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| To support a new use case where `iRonoc` owns an interface but the implementation lives in a separate module or repository, a shared protobuf contract now lives at: | ||
|
|
||
| `/home/runner/work/ironoc/ironoc/src/main/proto/ironoc/portfolio/v1/portfolio_projects.proto` |
Comment on lines
+226
to
+229
| protoc \ | ||
| --proto_path=src/main/proto \ | ||
| --java_out=/path/to/generated-sources \ | ||
| src/main/proto/ironoc/portfolio/v1/portfolio_projects.proto |
Comment on lines
+24
to
+25
| string image_theme = 5; | ||
| string image_alt = 6; |
Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/627d7008-c5c0-4167-b2ec-094d79ec684d Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate the use of gprc proto interfaces for new use case
Add shared gRPC proto contract for portfolio items
May 16, 2026
conorheffron
marked this pull request as ready for review
May 16, 2026 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This spike explores defining the service interface in
ironocwhile leaving implementation to a separate module or repository. It introduces a contract-only protobuf definition for the existing portfolio-items use case so downstream services can generate shared types and implement the interface independently.What changed
src/main/proto/ironoc/portfolio/v1/portfolio_items.protoPortfolioItemsServicegRPC surface with aListPortfolioItemsRPCPortfolioItemto match the current portfolio item payload shape used byironocContract shape
page_sizepage_tokenitemsnext_page_tokenDocumentation
README.mdwith the contract location,protocgeneration example, and intended usage pattern for external modules/projectsIntended use
ironocremains the owner of the interface definition