Skip to content

Refactor GitHub API client to Spring RestTemplate with template-based URI expansion - #657

Merged
conorheffron merged 14 commits into
mainfrom
copilot/refactor-migrate-to-spring-boot-rest-template
May 17, 2026
Merged

Refactor GitHub API client to Spring RestTemplate with template-based URI expansion#657
conorheffron merged 14 commits into
mainfrom
copilot/refactor-migrate-to-spring-boot-rest-template

Conversation

Copilot AI commented May 16, 2026

Copy link
Copy Markdown
Contributor
  • Inspect current branch state and recent commit history
  • Fetch latest main branch history and attempt merge into PR branch
  • Resolve any merge conflicts in affected files with minimal changes
  • Run targeted tests for files touched by conflict resolution
  • Push resolved merge commit and reply on PR comment

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/d12ea468-41d4-412d-b2d3-0de30faf76b1

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>
Comment thread src/main/java/net/ironoc/portfolio/client/GitClient.java Fixed
Comment thread src/main/java/net/ironoc/portfolio/client/GitClient.java Dismissed
Copilot AI and others added 2 commits May 16, 2026 04:13
Copilot AI changed the title [WIP] Refactor API calls to use Spring Boot RestTemplate Refactor GitHub API client to Spring RestTemplate with template-based URI expansion May 16, 2026
@conorheffron conorheffron added java-be Java / Server Side Tasks java Pull requests that update Java code labels May 16, 2026
…forgery'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@conorheffron
conorheffron marked this pull request as ready for review May 16, 2026 14:45
@conorheffron conorheffron moved this from In progress to In review in @conorheffron's ironoc (portfolio site) May 16, 2026
@conorheffron

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>
Copilot AI and others added 2 commits May 16, 2026 15:16
Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>

Copilot AI commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Merge conflicts are resolved and pushed. I merged latest main into this PR branch and resolved the conflict in GitDetailsServiceTest in commit 7e3800c (with a follow-up cleanup in d755d85).

Copilot AI requested a review from conorheffron May 16, 2026 15:17
@conorheffron conorheffron added the enhancement New feature or request label May 16, 2026
Copilot AI added a commit that referenced this pull request May 16, 2026
Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/e2b11e10-6ecc-4eaa-acc1-152b5e8534f2

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>
Copilot AI added a commit that referenced this pull request May 16, 2026
Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>
conorheffron added a commit that referenced this pull request May 17, 2026
…eout properties, stable Selenium selectors (#663)

* Initial plan

* refactor: migrate GitClient API calls to RestTemplate

Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/d12ea468-41d4-412d-b2d3-0de30faf76b1

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>

* fix: harden GitClient URI validation for RestTemplate calls

Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/d12ea468-41d4-412d-b2d3-0de30faf76b1

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>

* refactor: build GitHub API URIs in GitClient from templates

Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/d12ea468-41d4-412d-b2d3-0de30faf76b1

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>

* fix: use short-circuit URL validation in GitDetailsService

Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/d12ea468-41d4-412d-b2d3-0de30faf76b1

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>

* Potential fix for pull request finding 'CodeQL / Server-side request forgery'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* merge: resolve conflicts with main in GitDetailsServiceTest

Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/f283bc18-6796-4d53-9e08-8542e2a29816

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>

* chore: restore frontend lockfile after merge conflict resolution

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>

* Initial plan

* Initial plan for fixing failing tests in PR #657

Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/e2b11e10-6ecc-4eaa-acc1-152b5e8534f2

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>

* Fix failing tests: GitClient URL allowlist stubs, integration test timeout props, stable Selenium selectors

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>

* Fix failing tests: integration test timeout props, stable Selenium CSS selectors for iRonoc nav

Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/e2b11e10-6ecc-4eaa-acc1-152b5e8534f2

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>

* Fix GitClient.java: initialize dtos as ArrayList and fix misleading blank-body error message

Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/e2b11e10-6ecc-4eaa-acc1-152b5e8534f2

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>
Co-authored-by: Conor Heffron <conor.heffron@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@conorheffron
conorheffron merged commit 13d05e8 into main May 17, 2026
8 of 10 checks passed
@conorheffron
conorheffron deleted the copilot/refactor-migrate-to-spring-boot-rest-template branch May 17, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java Pull requests that update Java code java-be Java / Server Side Tasks

Projects

Development

Successfully merging this pull request may close these issues.

Refactor: Migrate to spring boot rest template for all API calls

4 participants