Skip to content

Round brews carousel label edges and scope label styling to carousel captions - #677

Open
conorheffron with Copilot wants to merge 4 commits into
mainfrom
copilot/add-rounded-label-edges
Open

Round brews carousel label edges and scope label styling to carousel captions#677
conorheffron with Copilot wants to merge 4 commits into
mainfrom
copilot/add-rounded-label-edges

Conversation

Copilot AI commented May 23, 2026

Copy link
Copy Markdown
Contributor

The brews carousel labels (yellow title/ingredients blocks) currently render with square corners and inconsistent styling scope. This update rounds the label edges to match tile/container styling and tightens CSS targeting to only carousel labels.

  • UI styling update

    • Introduced a dedicated label class on brews carousel caption headings.
    • Applied rounded corners to the yellow label background.
  • Selector scoping fix

    • Replaced the broad h3, h5 selector pattern with a class-based selector under .carousel-caption to avoid unintended global h5 styling.
  • Component-level test coverage

    • Added an assertion that both title and ingredients headings in CoffeeCarousel carry the new label class.
// CoffeeCarousel.js
<h3 className="coffee-carousel-label">{item.title}</h3>
<h5 className="coffee-carousel-label">
  <b>Ingredients:</b> ...
</h5>
/* App.css */
.carousel-caption .coffee-carousel-label {
  background-color: yellow;
  width: 50%;
  margin: 0 auto;
  border-radius: 12px;
}

Reference screenshot from issue context:

Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/13033b62-cd79-4a9c-a074-3021264d2820

Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>
Copilot AI changed the title [WIP] Add rounded label edges on coffee items in brews carousel Round brews carousel label edges and scope label styling to carousel captions May 23, 2026
Copilot AI requested a review from conorheffron May 23, 2026 19:05
@conorheffron
conorheffron requested a review from Copilot May 24, 2026 14:33
@conorheffron conorheffron added ui-frontend javascript Pull requests that update Javascript code labels May 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Rounds the brews carousel yellow label corners and scopes the styling to a dedicated class to prevent the previous overly-broad h3, h5 selector from leaking onto unrelated headings.

Changes:

  • Added coffee-carousel-label class to the title (h3) and ingredients (h5) in CoffeeCarousel.
  • Replaced .carousel-caption h3, h5 with .carousel-caption .coffee-carousel-label and added border-radius: 12px.
  • Added a test asserting both headings carry the new class.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
frontend/src/components/CoffeeCarousel.js Adds coffee-carousel-label class to title and ingredients headings.
frontend/src/App.css Scopes the yellow label style to the new class and adds rounded corners.
frontend/src/components/tests/CoffeCarousel.test.js New test confirming both headings render with the new class.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@conorheffron
conorheffron marked this pull request as ready for review June 7, 2026 06:44
@conorheffron conorheffron moved this from In progress to In review in @conorheffron's ironoc (portfolio site) Jun 7, 2026
@conorheffron

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

Copilot AI added 2 commits July 4, 2026 17:24
…abel-edges

# Conflicts:
#	frontend/src/App.css
#	frontend/src/components/CoffeeCarousel.js
#	frontend/src/components/__tests__/CoffeCarousel.test.js
….css, CoffeeCarousel.js, CoffeCarousel.test.js

Copilot AI commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in commit a38fdc6. The three conflicted files were resolved as follows:

  • App.css — kept the scoped .carousel-caption .coffee-carousel-label selector (with border-radius: 12px) over the broad h3, h5 selector from main.
  • CoffeeCarousel.js — combined both changes: translatedTitle for the display text (from main) and coffee-carousel-label className on the h3 (from this branch).
  • CoffeCarousel.test.js — kept both tests: the label class assertion from this branch and the new translation test from main.

All 5 CoffeeCarousel tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code ui-frontend

Projects

Development

Successfully merging this pull request may close these issues.

As a user, I would like to see rounded label edges on the coffee items on the brews carousel

3 participants