Replace carousel item backgrounds with relevant image for portfolio item - #690
Open
conorheffron with Copilot wants to merge 12 commits into
Open
Replace carousel item backgrounds with relevant image for portfolio item#690conorheffron with Copilot wants to merge 12 commits into
conorheffron with Copilot wants to merge 12 commits into
Conversation
Agent-Logs-Url: https://github.com/conorheffron/ironoc/sessions/f08cfaa0-f8c4-4152-9cca-5382913849bc Co-authored-by: conorheffron <8218626+conorheffron@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the frontend portfolio carousel to display a more relevant background image per portfolio item by deriving the <img src> from either a provided image URL, a GitHub OpenGraph snapshot for GitHub repos, or a local color-based fallback.
Changes:
- Added helper logic in
ControlledCarouselto choose between directimgURLs, GitHub OpenGraph snapshot URLs, and local fallback images. - Updated the carousel rendering to use the new image-selection logic.
- Extended
ControlledCarouseltests to validate GitHub snapshot image selection and fallback behavior for non-GitHub links.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| frontend/src/components/ControlledCarousel.js | Adds URL validation + GitHub OpenGraph mapping and uses it for carousel item images. |
| frontend/src/components/tests/ControlledCarousel.test.js | Adds a non-GitHub item and a test asserting GitHub snapshot vs fallback image behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
conorheffron
marked this pull request as ready for review
June 1, 2026 01:12
conorheffron
approved these changes
Jul 4, 2026
conorheffron
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.