-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labs 1753/limit order arbitrum mainnet #38
base: limitorder-hosted-service
Are you sure you want to change the base?
Labs 1753/limit order arbitrum mainnet #38
Conversation
…er LimitOrder Subgraph 1) Add "prepare:arbitrum" and "deploy-staging:arbitrum" to package.json. However, if the corresponding exchange, staking, and limitorder are not supported, execute "echo ${NotUse}". 2) Update the version of Graph-CLI. 3) Add "limitorder.yaml" to .gitignore.
1) This version supports the Mainnet, Arbitrum, and Goerli networks. 2) This version includes the three main events of the LimitOrder: LimitOrderFilledByProtocol, LimitOrderFilledByTrader, and OrderCancelled. 3) This version also features the integrated LimitOrderFilled Entity, which combines the LimitOrderFilledByProtocol and LimitOrderFilledByTrader events. 4) Additionally, this version incorporates the updatable Order Entity, providing the ability to query the current status of orders.
1) Due to incompatibility between the ipfs-utils module and Node.js version 14, the Node.js parameter in GitHub CI has been updated to version 16. 2) Revised GraphQL query examples for the LimitOrder section.
subgraphs/limitorder/src/helper.ts
Outdated
const tokenAddr: Address = Address.fromBytes(tokenAddrBytes) | ||
let tokenAddrStr = tokenAddr.toHex() | ||
if (isETH(tokenAddr)) { | ||
tokenAddrStr = WETH_ADDRESS.toHex() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bug has been identified here.
When collecting TradedToken Entity, if the assetAddr is detected as of type WETH, it will be replaced with the Mainnet WETH address ("0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2") universally.
It should instead replace it with the WETH address on the respective network.
This issue will be addressed in the next commit.
…ith Mainnet address When collecting TradedToken Entity, if the assetAddr is detected to be of the WETH type, it is currently being universally replaced with the Mainnet WETH address. Instead, the intention is to replace it with the WETH address specific to that network.
What's the status of this PR? Still work in progress or ready to merge? |
This PR serves two main purposes and has one reason.
|
PR: LimitOrder Subgraph for Hosted Service on Mainnet, Arbitrum and Goerli
Major Changes
Other Changes
Deployment Process to "Subgraph Studio" Platform
GraphQL query examples for the LimitOrder subgraph