-
Notifications
You must be signed in to change notification settings - Fork 123
Apply code style fixes #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is this related any of existing issues?
- Does the PHP_CodeSniffer check (see
CONTRIBUTING.md) now pass?
|
I see.
It's not doing that currently. It makes sense to do only, when we fix all existing issues to avoid all new build be broken by default. |
|
checked |
|
Maybe can combine all CS fixes into single PR? I've just updated PHP_CodeSniffer also does support auto-fixing of most, but not all issues found. If you're using PhpStorm, then you configure it to automatically highlight problematic places. We're not using Scrutinizer CI or otherwise it will be showing CS issues online as well. |
|
You can squash merge from GitHub web UI if you have enabled that in project. If that's what you mean by single commit. |
|
At this moment, I do not plan to make more CS fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no more CS fixes are planned, then please adjust your fixes to match existing coding standard.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
=========================================
Coverage 62.18% 62.18%
Complexity 205 205
=========================================
Files 10 10
Lines 669 669
=========================================
Hits 416 416
Misses 253 253 ☔ View full report in Codecov by Sentry. |
|
Merging, thanks @glensc . |
Minor code style fixes done with help of php-cs-fixer.