Skip to content

Adjust "Api::createRemoteLink" params with Jira API params #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Jan 7, 2025

The following problems with the Api::createRemoteLink method are addressed:

  • don't specify the globalId and relationship parameters with NULL values to the Jira REST API call, because it's not a guaranteed behavior of Atlassian to ignore NULL values
  • made an $object method argument mandatory to be in line with an API specs
  • added test

Closes #120

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.52%. Comparing base (236316d) to head (6c93c57).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #231      +/-   ##
============================================
+ Coverage     63.17%   64.52%   +1.35%     
+ Complexity      208      207       -1     
============================================
  Files            10       10              
  Lines           687      685       -2     
============================================
+ Hits            434      442       +8     
+ Misses          253      243      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099 aik099 changed the title Don't specify optional API call parameters, when "Api::createRemoteLink" was called without them Adjust "Api::createRemoteLink" params with Jira API params Jan 7, 2025
@aik099 aik099 force-pushed the create-remote-link-fix branch from 798023e to 6c93c57 Compare January 7, 2025 17:16
@aik099 aik099 added the type-bug label Jan 7, 2025
@aik099 aik099 added this to the v2.0.0 milestone Jan 7, 2025
@aik099 aik099 merged commit c4c1d90 into console-helpers:master Jan 7, 2025
12 checks passed
@aik099 aik099 deleted the create-remote-link-fix branch January 7, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with "Api::createRemotelink" method
1 participant